New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add favicon to backbonejs.org #2883
Comments
Good catch. The docs page is generated by docco, which as far as I can tell doesn't accept a custom favicon without using a custom template. Might be worth adding as a feature. |
So it does :) That's because underscore.org has the favicon.ico file in the domain root, but in Backbone it's in a subdir. The behavior is deprecated and it's a little cleaner to put it with the rest of the docs assets, but I don't see any harm in moving it to the root. Any objections from anyone? edit: @dminkovsky pointed out that the favicon shows up on underscore.org's annotated docs. |
👍 for moving it to the root. |
Thanks very much. |
Should favicon.ico be added to bower.js' ignore list, now that it's no longer covered by the "docs" entry? |
Good call. 8429118 |
I use Chrome's "pin tab" feature, which makes things look like this:
One of the tabs in there is http://backbonejs.org/docs/backbone.html, but I can't tell which unless I remember.
Is there a favicon we can use for http://backbonejs.org/docs/backbone.html?
The text was updated successfully, but these errors were encountered: