Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify about failed tests even when all tests fail #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

d4goxn
Copy link

@d4goxn d4goxn commented Aug 21, 2015

When all tests fail, results.error = true. Do not return before notifying of failed tests.

When all tests fail, result.error = true. Do not return before notifying of failed tests.
@d4goxn
Copy link
Author

d4goxn commented Aug 21, 2015

To reproduce, make sure you have two failing tests and no passing tests. results.error will be true and you will not get a failure notification. If you fix one test, or add a third test that passes, results.error will be true and you will see a "x/y tests failed" notification.

OS: Ubuntu 14.04
Browser: Chromium 43.0.2357.130 (Developer Build)
Karma version: 0.13.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant