Skip to content
This repository has been archived by the owner on Oct 4, 2020. It is now read-only.

Dependabot #163

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Dependabot #163

wants to merge 7 commits into from

Conversation

zbeekman
Copy link

@zbeekman zbeekman commented Jul 8, 2019

Add a dependabot configuration file to get automatic dependency bumps for vulnerable dependencies.

You still need to sign up and enable dependabot here.

Also, I added a link in the related projects section of the README and fixed tslint violations and a vulnerable dependency.

However, when I try to compile (node on macOS) I get:

> eclint@2.8.1 compile /Users/ibeekman/Sandbox/eclint
> tsc

lib/cli.ts:247:3 - error TS2322: Type '(argv: IArgv) => Transform' is not assignable to type '(args: { [argName: string]: unknown; _: string[]; $0: string; }) => void'.
  Types of parameters 'argv' and 'args' are incompatible.
    Type '{ [argName: string]: unknown; _: string[]; $0: string; }' is missing the following properties from type 'IArgv': globs, alias, argv, array, and 59 more.

247     handler: check,
        ~~~~~~~

  node_modules/@types/yargs/index.d.ts:412:9
    412         handler: (args: Arguments<U>) => void;
                ~~~~~~~
    The expected type comes from property 'handler' which is declared here on type 'CommandModule<{}, {}>'


Found 1 error.

I'm not a js/ts programmer, so this is beyond my "googling for a fix" skill level to resolve. (I tried for a while.)

 - Add [dependabot] support
 - Need to activate account for this project at
   https://app.dependabot.com/auth/sign-up
 - Keep dependencies up-to-date automatically
 - Not currently configured for auto-merging of PRs
 - Add a link to EditorConfig-Action in the related projects section
@zbeekman
Copy link
Author

zbeekman commented Jul 8, 2019

454eac9 fixes #162

@zbeekman
Copy link
Author

zbeekman commented Jul 8, 2019

Failing tests are the same issue highlighted in the first comment/PR description

lib/cli.ts Outdated
@@ -232,7 +232,7 @@ function fix(argv: IArgv): Stream {

function infer(argv: IArgv): Stream {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zbeekman a way to make it compile. Ugly though.

Suggested change
function infer(argv: IArgv): Stream {
function infer(argv: any): Stream {

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@greut: That did not seem to resolve the problem (or, at least, it created a different one).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the other handlers needs to same treatment. Cheers mate and happy new year.

Co-Authored-By: Yoan Blanc <yoan@dosimple.ch>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants