Upgrade axios to 1.6.8 #156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcC399
reviewed
Mar 27, 2024
package-lock.json
Outdated
| @@ -1,44 +1,92 @@ | |||
| { | |||
| "name": "wait-on", | |||
| "version": "7.2.0", | |||
| "lockfileVersion": 1, | |||
| "lockfileVersion": 3, | |||
There was a problem hiding this comment.
Please check if updating the lockfileVersion to 3 would make it a breaking change.
The README claims compatibility for Node.js 12+
Node.js 12 however uses npm 6 which in turn uses lockfileVersion 1
https://docs.npmjs.com/cli/v10/configuring-npm/package-lock-json#lockfileversion
There was a problem hiding this comment.
My bad, my default node version is 18, didn't see the change in the lockfileVersion. Updated the PR after having installed deps with node 12.
naimdjon
force-pushed
the
nt/upgrade-axios
branch
from
22a4dc5
to
8624387
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades axios to 1.6.8 in order to mitigate the security vulnerability in the transitive dependency
follow-redirects.