Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve accessibility of the docs #9338

Merged
merged 17 commits into from
Jan 12, 2024
Merged

Improve accessibility of the docs #9338

merged 17 commits into from
Jan 12, 2024

Commits on Apr 8, 2023

  1. Refactored linkifyAnchors function 

    This update refactors the `linkifyAnchors` function to use arrow function syntax and the `Array.from()` method to convert the result of `getElementsByTagName()` to an array. The update also uses template literals to clean up the anchor.href assignment. Additionally, `var` declarations are replaced with `const` or `let`.
    @danielhaim1
    danielhaim1 committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    5c2257b View commit details
    Browse the repository at this point in the history

  2. Updated syntax for navigation menu 

    Revised liquid syntax for navigation menu with additional variables, reducing lines of code.
    @danielhaim1
    danielhaim1 committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    eaef09c View commit details
    Browse the repository at this point in the history

  3. Refactor navigation for docs on mobile 

    The change involves removing unnecessary hyphen in the `for` loops, but otherwise retains the original functionality of the navigation.
    @danielhaim1
    danielhaim1 committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    fce0a97 View commit details
    Browse the repository at this point in the history

  4. + ARIA label to .docs-nav-mobile

    @danielhaim1
    danielhaim1 committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    7d1b51d View commit details
    Browse the repository at this point in the history

  5. Update anchor_links.html 

    - Added aria-hidden="true" to the i tag to indicate that it doesn't provide any important information for assistive technologies
    @danielhaim1
    danielhaim1 committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    41841b3 View commit details
    Browse the repository at this point in the history

  6. aria-current +

    @danielhaim1
    danielhaim1 committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    8a75c14 View commit details
    Browse the repository at this point in the history

  7. en-US to en 

    The language attribute "en-US" is not necessary because "en" is sufficient to indicate the document's language as English, and any regional variations can be conveyed through other means such as regional dialect or locale-specific settings.
    @danielhaim1
    danielhaim1 committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    d8a8d3e View commit details
    Browse the repository at this point in the history

  8. lowercase HTML in doctype 

    Both <!DOCTYPE html> and <!DOCTYPE HTML> are valid ways to declare the document type for HTML5 documents. However, it's recommended to use <!DOCTYPE html>
    @danielhaim1
    danielhaim1 committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    7cf33d7 View commit details
    Browse the repository at this point in the history

  9. search ARIA

    @danielhaim1
    danielhaim1 committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    86dd50f View commit details
    Browse the repository at this point in the history

  10. scripts.html, defer 

    Added defer attribute to script for faster page load.
    @danielhaim1
    danielhaim1 committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    7e6e017 View commit details
    Browse the repository at this point in the history

  11. moved navigateToUrl to footer 

    - added accessibility to mobile navigation
- moved navigateToUrl to footer
    @danielhaim1
    danielhaim1 committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    f99d0d8 View commit details
    Browse the repository at this point in the history

  12. structured data schema for news articles

    @danielhaim1
    danielhaim1 committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    6947c5c View commit details
    Browse the repository at this point in the history

  13. structured data schema for news articles

    @danielhaim1
    danielhaim1 committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    ae27780 View commit details
    Browse the repository at this point in the history

  14. structured data schema for news articles

    @danielhaim1
    danielhaim1 committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    3f604f8 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Updated Comment Style and Fixed Quotation Marks in news_item_archive.… 

    …html

- Converted inline comments from single-line (//) to block style (/* */).
- Amended double quotation marks in news_item_archive.html to rectify an error.
    @danielhaim1
    danielhaim1 committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    5a927fa View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2024

  1. Update docs/_includes/anchor_links.html 

    Co-authored-by: Matt Rogers <mattr-@github.com>
    @danielhaim1 @mattr-
    danielhaim1 and mattr- committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    892cc17 View commit details
    Browse the repository at this point in the history

  2. Update docs/_includes/anchor_links.html 

    Co-authored-by: Matt Rogers <mattr-@github.com>
    @danielhaim1 @mattr-
    danielhaim1 and mattr- committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    6e90011 View commit details
    Browse the repository at this point in the history