Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support reconnecting players to cluster #364

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jeremylvln
Copy link
Owner

Using the new transfer packets, we can now finish properly the proxy drain feature by reconnecting the players automatically when the TTL is expired.

Also, expose the method in the API if custom plugins want to re-use this capability.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (493ba07) 31.11% compared to head (d9b2141) 31.22%.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #364      +/-   ##
==========================================
+ Coverage   31.11%   31.22%   +0.10%     
==========================================
  Files          58       58              
  Lines        3137     3142       +5     
==========================================
+ Hits          976      981       +5     
  Misses       2161     2161              
Flag Coverage Δ
shulker-operator 58.42% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...lker-operator/src/reconcilers/proxy_fleet/fleet.rs 80.09% <100.00%> (+0.46%) ⬆️

.withName(Configuration.PROXY_FLEET_NAME)
.get()

if (service.spec.type !== "LoadBalancer") {

Check warning

Code scanning / detekt

Avoid using referential equality and prefer to use referential equality checks instead. Warning

Checking referential equality may lead to unwanted results.
@TehNeon
Copy link

TehNeon commented Mar 26, 2024

One thing that would be nice is to have some sort of way to override the IP/Hostname it will transfer the users to. In my planned usage case I intend to be running on bare metal and utilizing an external DDoS protection provider (i.e TCPShield) which would require me to re-route the players to a specific hostname.

@jeremylvln
Copy link
Owner Author

One thing that would be nice is to have some sort of way to override the IP/Hostname it will transfer the users to. In my planned usage case I intend to be running on bare metal and utilizing an external DDoS protection provider (i.e TCPShield) which would require me to re-route the players to a specific hostname.

This would be a nice addition, indeed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants