Added expect.satisfies(predicate) matcher #14145
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new matcher,
expect.satisfies(predicate)
, similar totoSatisfy
matcher from thejest-extended
package but implemented as an asymmetric matcher for more flexibility. It is useful for composing with other expectation functions to test for arbitrary conditions without going outside theexpect(subject).toVerb(object)
pattern.For example, consider the example code for
expect.objectContaining(object)
, but modified to accept only even numbers:Without
expect.satisfies
, theexpect
call has to be totally rewritten in a way that's harder to read and produces much less helpful error messages:For further motivation, consider the Truly matcher from Gtest, which is used in numerous places in Chromium.
Test plan
This PR includes full unit tests for the new functionality.