Use explicit signed char types for 'level' variable.

The char type is not standardised as either signed or unsigned, and depends on the architecture. In particular, on PowerPC-based Linux systems, char is by default unsigned. Where it matters, make sure that char has its signedness explicited in the code.
jgarber · Mar 1, 2010 · e71fb12 · e71fb12
1 parent f4918b5
commit e71fb12
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/ext/redcloth_scan/redcloth.h b/ext/redcloth_scan/redcloth.h
@@ -129,7 +129,7 @@ VALUE red_pass_code(VALUE, VALUE, VALUE, ID);
         case ')': \
           { /*needed to keep inside chars scoped for less memory usage*/\
             char *temp_p = p - 1; \
-            char level = -1; \
+            signed char level = -1; \
             while (temp_p > reg) { \
               switch(*(temp_p - 1)) { \
                 case '(': ++level; break; \

diff --git a/ext/redcloth_scan/redcloth_inline.c.rl b/ext/redcloth_scan/redcloth_inline.c.rl
@@ -56,7 +56,7 @@ red_parse_title(VALUE self, VALUE regs, VALUE ref)
   if ( txt != Qnil ) {
     char *p = RSTRING_PTR(txt) + RSTRING_LEN(txt);
     if (*(p - 1) == ')') {
-      char level = -1;
+      signed char level = -1;
       p--;
       while (p > RSTRING_PTR(txt) && level < 0) {
         switch(*(p - 1)) {