Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inline org links #8482

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tillydray
Copy link

@tillydray tillydray commented Dec 12, 2022

closes #8470

Not sure if this is what you want, or even if it fixes it. I'm still building so haven't run the tests yet. But in case I get distracted and forget to come back to this for days, at least there's a PR

@tillydray
Copy link
Author

I tested locally and this isn't working as intended. Example

# working as intended
[[hcp-nrsvuebib-0007.xhtml_reader][To the Reader]]

...

# should replace '#' with '_'
<<hcp-nrsvuebib-0007.xhtml#reader>>
# doesn't match the above link at all
[[hcp-nrsvuebib-0005.xhtml_rreader][To the Reader]]

In case it isn't clear and it's relevant, the first line above is on one of the first pages, while the second two lines are next to one another and are over 1,700 lines further down

@tarleb
Copy link
Collaborator

tarleb commented Dec 16, 2022

LGTM. Could you re-add the old test and add the new one as an extra test?

@tillydray
Copy link
Author

@tarleb I'm not sure this PR is correct. The test I removed and the test I added cannot co-exist. Plus my change doesn't fix the problem. I'm hoping someone can give me some direction here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline links seem broken when converting de-drm epub to org file
2 participants