Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encode entity "greater-than" (>) in text node #199

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lseguin42
Copy link

@lseguin42 lseguin42 commented Feb 19, 2017

On browser :
new DOMParser().parseFormString('<div>]]></div>', 'text/xml');
this code throw an error.

we need to encode '>' for fix it.

@reebayroo
Copy link

Hey @lseguin42 how do you run the tests? npm test just runs a single one.

@Holzhaus
Copy link

I just ran node test/index.js. Anyway, this PR is chaotic beacause there are loads of completely unrelated whitespace changes. IMHO, this should be closed in favour of PR #207, which only escapes > if it was preceded by ]] (in accordance with Section 2.4. of the XML 1.0 spec).

@lviggiani
Copy link

Not encoding > to &gt; casues a lot of troubles if the try to format (pretty print) serialised XML text. It would be very helpful to have this pull request merged IMHO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants