Export DOM classes #238
Open
Export DOM classes #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exports the classes for Document, DocumentFragment, Element, NodeList and LiveNodeList, to allow them to be extended and modified by clients implementing this library.
ghost
suggested changes
Oct 16, 2018
There was a problem hiding this comment.
Hello, I think LiveNodeList should not be exported since it does not appear to be exposed by the DOM standard (https://www.w3.org/TR/DOM-Level-3-Core/ecma-script-binding.html).
Nit: if you keep the exports splitted into three groups then maybe add a short comment between each group. Or you can also merge all them together into a single alphabetical list without line breaks.
|
In fact, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exports the classes for
Document,DocumentFragment,Element,NodeListandLiveNodeList, to allow them to be extended and modified by clients implementing this library.Partly addresses #235.