Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/optional velocity threshold #171

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kanelloc
Copy link

@kanelloc kanelloc commented Dec 16, 2022

Summary

  • Added a new optional property swipeCloseVelocity to override the default valueSWIPE_CLOSE_VELOCITY

This PR solves the following issue: #165

@kanelloc
Copy link
Author

kanelloc commented Dec 16, 2022

Hey @antonKalinin 👋
Can you check this PR to solve the attached issue?

Thanks 😄

@kanelloc
Copy link
Author

Hey @maksimko 👋
Can you check this PR to solve the attached issue?
Thanks 😆

@UchennaOkafor
Copy link

@kanelloc

I wanted to use your branch, I did this in my packages.json file using yarn
"react-native-image-viewing": "kanelloc/react-native-image-viewing#feat/optional_velocity_threshold",

but now the import isn't working. I am importing it like this
import ImageView from "react-native-image-viewing";

but I am getting the following error message
Cannot find module 'react-native-image-viewing' or its corresponding type declarations.ts(2307)

Do you know why? Thanks

@seferdemirci
Copy link

@antonKalinin please merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants