Skip to content

Commit

Permalink
Corrected a silly mistake that caused signal injections to break. I w…
Browse files Browse the repository at this point in the history
…as creating a child injector for the SignalCommandMap, but it needs the parent injector that will supply singal injections to actors in the application.
  • Loading branch information
joelhooks committed Jun 3, 2010
1 parent 38fc3a0 commit 747f973
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 1 addition & 3 deletions src/org/robotlegs/base/SignalCommandMap.as
Expand Up @@ -106,9 +106,7 @@ package org.robotlegs.base
tempInjector.mapValue(valueConstructor, value);
}

var command:Object = tempInjector.instantiate(commandClass);

return command;
return tempInjector.instantiate(commandClass);

This comment has been minimized.

Copy link
@joelhooks

joelhooks Jun 3, 2010

Author Owner

This didn't actually have anything to do with the problem, but IntelliJ suggested I do it so I complied ;)

}

protected function getConstructorForObject(object:Object):Class
Expand Down
2 changes: 1 addition & 1 deletion src/org/robotlegs/mvcs/SignalContext.as
Expand Up @@ -16,7 +16,7 @@ package org.robotlegs.mvcs

public function get signalCommandMap():ISignalCommandMap
{
return _signalCommandMap || (_signalCommandMap = new SignalCommandMap(injector.createChild()));

This comment has been minimized.

Copy link
@joelhooks

joelhooks Jun 3, 2010

Author Owner

This approach works fine in regular CommandMap because events don't actually get injected all over the place like Signals do.

return _signalCommandMap || (_signalCommandMap = new SignalCommandMap(injector));
}

public function set signalCommandMap(value:ISignalCommandMap):void
Expand Down

0 comments on commit 747f973

Please sign in to comment.