escape apostrophe/single quote

closes mlawren#1
joenio · Nov 29, 2015 · 639925f · 639925f
1 parent 069eeb0
commit 639925f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/lib/XML/API.pm b/lib/XML/API.pm
@@ -891,12 +891,13 @@ sub _fast_string {
 sub _escapeXML {
     my $data = $_[0];
     return '' unless(defined($data));
-    if ($data =~ /[\&\<\>\"(__AMP__)]/o) {
+    if ($data =~ /[\&\<\>\"(__AMP__)\']/o) {
         $data =~ s/\&(?!\w+\;)/\&amp\;/go;
         $data =~ s/\</\&lt\;/go;
         $data =~ s/\>/\&gt\;/go;
         $data =~ s/\"/\&quot\;/go;
         $data =~ s/__AMP__/\&/go;
+        $data =~ s/\'/\&apos\;/go;
     }
     return $data;
 }

diff --git a/t/04-parse.t b/t/04-parse.t
@@ -1,6 +1,6 @@
 use strict;
 use warnings;
-use Test::More tests => 9;
+use Test::More tests => 10;
 use Test::Exception;
 use Test::Memory::Cycle;
 
@@ -63,4 +63,8 @@ is("$x", '<?xml version="1.0" encoding="UTF-8" ?>
 
 memory_cycle_ok($x, 'memory cycle');
 
-
+is(XML::API::_escapeXML(
+    " ' "
+),
+    " &apos; ",
+'escape apostrophe/single quote');