Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Closes #37
Types of changes
This completes the documentation for simhyd. However, I have split the simhyd.R code to have a separate simhydrouting.R as this was cleaner and follows the "sma" and "routing" convention better. I hope this does not break any other features. The documentation for the routing and simhyd is similar except for the parameters.
It is still giving me the testthat error, even though I am even with the master from Joseph
== testthat results ========================================
[ OK: 256 | SKIPPED: 3 | WARNINGS: 22 | FAILED: 1 ]