wxPython 4/TextEntryDialog: use 'value' instead of 'defaultValue'. Re n…

…vaccess#8523. Regression: wx.TextEntryDialog no longer accepts defaultValue kwarg, replaced by just 'value'. This affected edit command dialog in Excel and rename function in config profiles dialog (Control+NVDA+P).
josephsl · Jul 19, 2018 · 4f68b13 · 4f68b13
1 parent e409638
commit 4f68b13
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/source/NVDAObjects/window/excel.py b/source/NVDAObjects/window/excel.py
@@ -1403,7 +1403,7 @@ def script_editComment(self,gesture):
 			_("Editing comment for cell {address}").format(address=self.cellCoordsText),
 			# Translators: Title of a dialog edit an Excel comment 
 			_("Comment"),
-			defaultValue=commentObj.text() if commentObj else u"",
+			value=commentObj.text() if commentObj else u"",
 			style=wx.TE_MULTILINE|wx.OK|wx.CANCEL)
 		def callback(result):
 			if result == wx.ID_OK:

diff --git a/source/gui/configProfiles.py b/source/gui/configProfiles.py
@@ -218,7 +218,7 @@ def onRename(self, evt):
 		# Translators: The label of a field to enter a new name for a configuration profile.
 		with wx.TextEntryDialog(self, _("New name:"),
 				# Translators: The title of the dialog to rename a configuration profile.
-				_("Rename Profile"), defaultValue=oldName) as d:
+				_("Rename Profile"), value=oldName) as d:
 			if d.ShowModal() == wx.ID_CANCEL:
 				return
 			newName = api.filterFileName(d.Value)