Skip to content
This repository has been archived by the owner on Apr 11, 2020. It is now read-only.

Small tweaks to compress.rb (optional PNG grid flag, fixed semantic classes for ruby 1.9+) #20

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

nemoDreamer
Copy link

ChunkyPNG seems to be flaky on a lot of peoples dev environments, so i made it optional w/ the -g flag.
Semantic Classes was using Array's implicit .to_s, which causes a ["...", "..."] output in newer versions of Ruby.

@joshuaclayton
Copy link
Owner

@nemoDreamer It looks like the build is failing - mind getting this working so I can merge?

@nemoDreamer
Copy link
Author

Will do! Thanks for considering it ;)

On Fri, Nov 8, 2013 at 3:01 PM, Joshua Clayton notifications@github.comwrote:

@nemoDreamer https://github.com/nemoDreamer It looks like the build is
failing - mind getting this working so I can merge?


Reply to this email directly or view it on GitHubhttps://github.com//pull/20#issuecomment-28093299
.

This is a `chunky_png` wrapper w/ more support across platforms.
@nemoDreamer
Copy link
Author

Travis seems to be failing on:

$ bundle install --deployment
Fetching gem metadata from http://rubygems.org/.........
Fetching gem metadata from http://rubygems.org/..
Could not find ffi-1.0.8 in any of the sources

ffi is a chunky_png dependency which seems to have had problems around the time I submitted this pull request.
I switched to oily_png, as that is generally a good thing to do if you want more platforms to be able to compress.rb their own source.

multi_json (1.9.2)
nokogiri (1.6.1)
mini_portile (~> 0.5.0)
oily_png (1.1.1)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oily_png wraps chunky_png

@nemoDreamer
Copy link
Author

Travis is failing on:

An error occurred while installing capybara-webkit (0.3.0), and Bundler cannot

continue.

Are you sure Travis ever worked for you?
I see from the previous pull-request builds in your queue that bundler was always failing:
https://travis-ci.org/joshuaclayton/blueprint-css/builds/3804122

@nemoDreamer
Copy link
Author

Any news on fixing the Travis config?

@nemoDreamer
Copy link
Author

This and all other pull-requests will fail, since the base build in https://github.com/joshuaclayton/blueprint-css/tree/master is broken. Attempting to fix it in #21.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants