Added new color variable #93
Conversation
Added a background color variable for memdoc & memdesc
|
Sry for not reaching out to you for so long. Did you intend to also change the Can you help me with how & were this change affects the theme? |
|
apologies for the late reply. yes, i did, but for dark mode only. as for light mode i've left the original colors unchanged. Sure, but the changes that i've made are only tested on docs.wxwidgets.org website ,
|
|
as for and that's pretty much it. |
There was a problem hiding this comment.
Thanks for the detailed explanation!
I like the concept of coloring the brief description (.mdescLeft, .mdescRight) in the same color as the member documentation (.memdoc), but I think it needs some polishing and I'm not yet convinced that I want to make it the default.
Pls bear with me, it may take some time to figure out how this can be done and if I can bring it to main. In any case consider sharing your customization here so others can adopt it and give feedback while I am still hesitant. 🙈
| --primary-dark-color: #86a9c4; | ||
| --primary-dark-color: #ddb582; |
There was a problem hiding this comment.
The new colors that you choose for WxWidgets look great IMO! I'd like to keep the original colors as default though, for both variables, --primary-dark-color and --fragment-desc-background.
| @@ -1791,7 +1794,7 @@ table.memberdecls .memItemRight { | |||
| } | |||
|
|
|||
| table.memberdecls .mdescLeft, table.memberdecls .mdescRight { | |||
| background: none; | |||
| background: var(--fragment-desc-background); | |||
There was a problem hiding this comment.
I see a problem with this. It doesn't work well with the current design of the member overview. The block above has rounded corners and creates a small gap, which doesn't look nice IMO:
I'd like the background coloring of the brief description to be an option that can be enabled, but I'm not sure how this could be implemented atm. :/
There was a problem hiding this comment.
could be solved by removing border-right/left-radius for both .memItem left & right respectively,
also i'm not sure about border color (bottom) should it be left as it is, or removed too and added to mdesc's bottom as shown here:
or should it be just like this, no borders at all:
what do you think? ( and i truly appreciate the detailed feedback, thanks :) !)
Co-authored-by: jothepro <github@jothe.pro>
|
I am so sorry for not giving you any reply @NecrCode, I must have completely overlooked your response, I re-discovered it by accident rn! 😳 I will revisit your proposal in the next design iteration. I am not yet sure when this will happen, likely somewhere in the next 6 months. Stay tuned! |
| color: var(--page-foreground-color); | ||
| padding: var(--spacing-small) 0; | ||
| } | ||
|
|
||
| table.memberdecls .mdescLeft{ |
There was a problem hiding this comment.
alright, the small gap is no longer there, i was going to remove bottom border for memItemL/R, but it would look a bit weird when there's no mdescL/R, so that's why i left it as is.
Added a background color variable for memdoc & memdesc