This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Swipe event: Trigger only one event per mouse sequence and let it bubble #6946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 21, 2014 08:08
The element to which a mousedown handler is attached by the swipe setup() code takes ownership of the next swipe event. This means that, if the same mousedown event triggers other swipe setup() -attached mousedown handlers as it bubbles, the subsequent ones will bail. Thus, if a swipe event results from the mousedown then such a swipe event will be triggered on the deepest element with an attached swipe handler, and it will be allowed to bubble from there. This provides the tools that developers can use to avoid scenarios such as the one mentioned in the referenced issue. Fixes gh-6262
|
i think this looks good now just make sure to squash 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The element to which a mousedown handler is attached by the swipe setup() code
takes ownership of the next swipe event. This means that, if the same mousedown
event triggers other swipe setup() -attached mousedown handlers as it bubbles,
the subsequent ones will bail. Thus, if a swipe event results from the mousedown
then such a swipe event will be triggered on the deepest element with an
attached swipe handler, and it will be allowed to bubble from there. This
provides the tools that developers can use to avoid scenarios such as the one
mentioned in the referenced issue.
Fixes gh-6262