This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Flipswitch: Transfer tabindex to "on" button and make input unfocusable #6962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 17, 2014 11:15
The "on" button must be an anchor for it to be focusable just like an input even when it does not have an explicitly set tabindex. Although the input becomes unfocusable, a focus handler that transfers focus to the "on" button is nevertheless attached to it in case third-party code focuses the input manually. Fixes gh-6955
| // Transfer tabindex to "on" element and make input unfocusable | ||
| $.extend( this, { | ||
| _originalTabIndex: this.element.attr( "tabindex" ) | ||
| }); |
There was a problem hiding this comment.
So after a talk i had with scott a little while back we dont need to use extend in create in widgets. Its safe to just do this.propToSet = "value"; because this is not a dom node.
ghost
assigned
| */ | ||
| (function($){ | ||
|
|
||
| var testFocusTransfer = function( el ) { |
| }); | ||
| test( "select based flipswitch is untabbable", function() { | ||
| deepEqual( parseInt( $( "#flip-select" ).attr( "tabindex" ) ), -1, "tabindex is set to -1" ); | ||
| }); |
|
👍 after fix |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "on" button must be an anchor for it to be focusable just like an input even
when it does not have an explicitly set tabindex. Although the input becomes
unfocusable, a focus handler that transfers focus to the "on" button is
nevertheless attached to it in case third-party code focuses the input manually.
Fixes gh-6955