Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Selectmenu: Delay trigger until after the list closes #7197

Closed
wants to merge 3 commits into from
Closed

Selectmenu: Delay trigger until after the list closes #7197

wants to merge 3 commits into from

Conversation

gabrielschulhof
Copy link

Fixes gh-7076

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 4116f85 on 7076-delay-value-change-trigger into 00e80c9 on master.

@gabrielschulhof gabrielschulhof added this to the 1.4.3 milestone Feb 28, 2014
arschmitz
arschmitz reviewed May 29, 2014
View reviewed changes
tests/integration/select/select_core.js
openevent: openEvent
},
function() {
$.event.trigger = replacementTrigger;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be done as part of setup and teardown

gabrielschulhof pushed a commit that referenced this pull request May 29, 2014
Selectmenu: Delay trigger until after the list closes
e758e34 
Closes gh-7197
Fixes gh-7076
@coveralls
Copy link

Coverage Status

Coverage increased (+0.12%) when pulling e758e34 on 7076-delay-value-change-trigger into 7b818d8 on master.

arschmitz
arschmitz reviewed Jun 2, 2014
View reviewed changes
js/widgets/forms/select.custom.js
// trigger change if value changed
if ( self.isMultiple || oldIndex !== newIndex ) {
self.select.trigger( "change" );
// if it's not a multiple select, trigger change after it has finished closing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize first word of comments

@coveralls
Copy link

Coverage Status

Coverage increased (+0.35%) when pulling f2f89c3 on 7076-delay-value-change-trigger into 7b818d8 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.11%) when pulling 9c2ea16 on 7076-delay-value-change-trigger into 44f503d on master.

@arschmitz
Copy link
Contributor

👍

gabrielschulhof pushed a commit that referenced this pull request Jun 6, 2014
Selectmenu: Delay trigger until after the list closes
ea0533f 
(cherry picked from commit dde4873)

Closes gh-7197
Fixes gh-7076
@gabrielschulhof gabrielschulhof deleted the 7076-delay-value-change-trigger branch June 6, 2014 05:16
agcolom pushed a commit to agcolom/jquery-mobile that referenced this pull request Nov 26, 2014
@agcolom
Selectmenu: Delay trigger until after the list closes
436a2f1 
Closes jquery-archivegh-7197
Fixes jquery-archivegh-7076
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@arschmitz arschmitz

Labels
Component: Selectmenu
Projects
None yet
Milestone
1.4.3
Development

Successfully merging this pull request may close these issues.

Closing dialog on selectmenu change value event
3 participants
@gabrielschulhof @coveralls @arschmitz