This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Do not unconditionally add "//" to absolute URLs and handle authority-less URLs #7263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 8, 2014 09:55
Note: this does indeed represent a fix for gh-6574, but only once a version of Cordova sporting apache/cordova-wp8#30 is released. Closes gh-6597 Fixes gh-6574 Fixes gh-6599
| // Always use our own URL parser, even though location potentially provides all the | ||
| // fields we may need later on. This way, URL parsing is consistent, and we only | ||
| // grab location.href from the browser. | ||
| var uri = this.parseUrl( url || location.href ), |
There was a problem hiding this comment.
Can you please provide examples where the built in parser is inconsistent or incorrect? Those should be in the comment
There was a problem hiding this comment.
Well, TBH, I think I was thinking of #6810 at the time, but we can't reproduce that one. If the location.host is empty on Android 4.4, then we're better of never relying on it.
There was a problem hiding this comment.
... so, I'm not sure if that counts as an example.
There was a problem hiding this comment.
Actually, I've found another reason to do our own parsing. location does not provide the doubleSlash property. Our parser does provide this property, and now that we're not unconditionally appending the double slash, we need it below.
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navigation: Test authority-less protocols with path.getLocation()
Navigation: Do not assume "//" is always part of an absolute URL
Navigation: Expect a trailing slash when testing path.getLocation()
Note: this does indeed represent a fix for gh-6574, but only once a version of
Cordova sporting apache/cordova-wp8#30 is released.
Closes gh-6597
Fixes gh-6574
Fixes gh-6599