Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update additional-methods.js #578

Closed
wants to merge 1 commit into from

Conversation

trevorgehman
Copy link

Need to change the custom method "skip_or_fill_minimum", otherwise the entire form will submit if just those fields are valid (even if other fields are invalid).

The author notes this change here, but it was not implemented here: http://stackoverflow.com/questions/1888976/jquery-validate-either-skip-these-fields-or-fill-at-least-x-of-them

Need to change the custom method "skip_or_fill_minimum", otherwise the entire form will submit if just those fields are valid (even if other fields are invalid).

The author notes this change here, but it was not implemented here: http://stackoverflow.com/questions/1888976/jquery-validate-either-skip-these-fields-or-fill-at-least-x-of-them
@jzaefferer
Copy link
Collaborator

That method is broken, right, but calling validate is also wrong - what is that supposed to do when called on regular elements?

Would appreciate if you could update this to include a proper fix.

@jzaefferer
Copy link
Collaborator

Actually the correct way is likely to call this.check... for each element.

@jzaefferer
Copy link
Collaborator

Updated #412 to reference both broken methods. Will implement the this.check approach to fix that.

@jzaefferer jzaefferer closed this Feb 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants