Skip to content

Commit

Permalink
Tabs: Removed all templating features. Fixes #7158 - Tabs: Remove add…
Browse files Browse the repository at this point in the history
… and remove methods. Fixes #7157 - Tabs: Remove templating (idPrefix, tabTemplate, panelTemplate options). Fixes #7149 - Tabs: Remove use of title attribute.
  • Loading branch information
scottgonzalez committed Oct 25, 2012
1 parent 056f83f commit 054b208
Show file tree
Hide file tree
Showing 10 changed files with 2 additions and 504 deletions.
1 change: 0 additions & 1 deletion build/tasks/testswarm.js
Expand Up @@ -29,7 +29,6 @@ var versions = {
//"sortable/sortable.html",
"Spinner": "spinner/spinner.html",
"Tabs": "tabs/tabs.html",
"Tabs_deprecated": "tabs/tabs_deprecated.html",
"Tooltip": "tooltip/tooltip.html",
"Widget": "widget/widget.html"
};
Expand Down
2 changes: 1 addition & 1 deletion grunt.js
Expand Up @@ -281,7 +281,7 @@ grunt.initConfig({
files: grunt.file.expandFiles( "tests/unit/**/*.html" ).filter(function( file ) {
// disabling everything that doesn't (quite) work with PhantomJS for now
// TODO except for all|index|test, try to include more as we go
return !( /(all|all-active|index|test|draggable|droppable|selectable|resizable|sortable|dialog|slider|datepicker|tabs|tabs_deprecated|tooltip)\.html$/ ).test( file );
return !( /(all|all-active|index|test|draggable|droppable|selectable|resizable|sortable|dialog|slider|datepicker|tabs|tooltip)\.html$/ ).test( file );
})
},
lint: {
Expand Down
1 change: 0 additions & 1 deletion tests/unit/all-active.html
Expand Up @@ -36,7 +36,6 @@
//"sortable/sortable.html",
"spinner/spinner.html",
"tabs/tabs.html",
"tabs/tabs_deprecated.html",
"tooltip/tooltip.html",
"widget/widget.html"
];
Expand Down
1 change: 0 additions & 1 deletion tests/unit/all.html
Expand Up @@ -36,7 +36,6 @@
//"sortable/sortable.html",
"spinner/spinner.html",
"tabs/tabs.html",
"tabs/tabs_deprecated.html",
"tooltip/tooltip.html",
"widget/widget.html"
];
Expand Down
3 changes: 1 addition & 2 deletions tests/unit/subsuite.js
Expand Up @@ -8,8 +8,7 @@ var versions = [
],
additionalTests = {
accordion: [ "accordion_deprecated.html" ],
position: [ "position_deprecated.html" ],
tabs: [ "tabs_deprecated.html" ]
position: [ "position_deprecated.html" ]
};

window.testAllVersions = function( widget ) {
Expand Down
3 changes: 0 additions & 3 deletions tests/unit/tabs/tabs.html
Expand Up @@ -5,9 +5,6 @@
<title>jQuery UI Tabs Test Suite</title>

<script src="../../jquery.js"></script>
<script>
$.uiBackCompat = false;
</script>
<link rel="stylesheet" href="../../../external/qunit.css">
<script src="../../../external/qunit.js"></script>
<script src="../../jquery.simulate.js"></script>
Expand Down
23 changes: 0 additions & 23 deletions tests/unit/tabs/tabs_common_deprecated.js

This file was deleted.

156 changes: 0 additions & 156 deletions tests/unit/tabs/tabs_deprecated.html

This file was deleted.

4 comments on commit 054b208

@rosenfeld
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our code currently makes use of tabTemplate. What should we use instead now that it has been removed?

@rosenfeld
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we also use "add" and "remove" too. Is this gone forever? Is there any alternatives for more control over tabs templating and behavior?

@jzaefferer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rosenfeld
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the reference, @jzaefferer!

The document only references "refresh", which is great, but I couldn't find how to detect the close event and take some action upon its occurrence (old "remove" option).

Please sign in to comment.