Skip to content

Commit

Permalink
Core (widget): don't pass DOM objects to $.fn.add. Fixes #5743 ($.fn.…
Browse files Browse the repository at this point in the history
…remove does not trigger remove event for <select>s)
  • Loading branch information
sciyoshi authored and scottgonzalez committed Jul 8, 2010
1 parent 594b7f5 commit 89c0961
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ui/jquery.ui.widget.js
Expand Up @@ -15,7 +15,7 @@ $.fn.remove = function( selector, keepData ) {
return this.each(function() {
if ( !keepData ) {
if ( !selector || $.filter( selector, [ this ] ).length ) {
$( "*", this ).add( this ).each(function() {
$( "*", this ).add( [ this ] ).each(function() {
$( this ).triggerHandler( "remove" );
});
}
Expand Down

3 comments on commit 89c0961

@scottgonzalez
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sciyoshi Can you please sign our CLA?

@sciyoshi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed :)

@scottgonzalez
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Please sign in to comment.