Skip to content

Commit

Permalink
Widget: Added window and document properties. Fixes #7801 - Widget: A…
Browse files Browse the repository at this point in the history
…dd document and window properties.
  • Loading branch information
scottgonzalez committed Oct 20, 2011
1 parent c145f16 commit a0856ef
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 19 deletions.
11 changes: 5 additions & 6 deletions ui/jquery.ui.autocomplete.js
Expand Up @@ -47,7 +47,6 @@ $.widget( "ui.autocomplete", {

_create: function() {
var self = this,
doc = this.element[ 0 ].ownerDocument,
// Some browsers only repeat keydown events, not keypress events,
// so we use the suppressKeyPress flag to determine if we've already
// handled the keydown event. #7269
Expand Down Expand Up @@ -197,7 +196,7 @@ $.widget( "ui.autocomplete", {
};
this.menu = $( "<ul></ul>" )
.addClass( "ui-autocomplete" )
.appendTo( $( this.options.appendTo || "body", doc )[0] )
.appendTo( this.document.find( this.options.appendTo || "body" )[0] )
// prevent the close-on-blur in case of a "slow" click on the menu (long mousedown)
.mousedown(function( event ) {
// clicking on the scrollbar causes focus to shift to the body
Expand All @@ -207,7 +206,7 @@ $.widget( "ui.autocomplete", {
var menuElement = self.menu.element[ 0 ];
if ( !$( event.target ).closest( ".ui-menu-item" ).length ) {
setTimeout(function() {
$( document ).one( 'mousedown', function( event ) {
self.document.one( 'mousedown', function( event ) {
if ( event.target !== self.element[ 0 ] &&
event.target !== menuElement &&
!$.contains( menuElement, event.target ) ) {
Expand Down Expand Up @@ -239,7 +238,7 @@ $.widget( "ui.autocomplete", {
previous = self.previous;

// only trigger when focus was lost (click on menu)
if ( self.element[0] !== doc.activeElement ) {
if ( self.element[0] !== self.document[0].activeElement ) {
self.element.focus();
self.previous = previous;
// #6109 - IE triggers two focus events and the second
Expand Down Expand Up @@ -273,7 +272,7 @@ $.widget( "ui.autocomplete", {
// turning off autocomplete prevents the browser from remembering the
// value when navigating through history, so we re-enable autocomplete
// if the page is unloaded before the widget is destroyed. #7790
this._bind( doc.defaultView, {
this._bind( this.window, {
beforeunload: function() {
this.element.removeAttr( "autocomplete" );
}
Expand All @@ -297,7 +296,7 @@ $.widget( "ui.autocomplete", {
this._initSource();
}
if ( key === "appendTo" ) {
this.menu.element.appendTo( $( value || "body", this.element[0].ownerDocument )[0] );
this.menu.element.appendTo( this.document.find( value || "body" )[0] );
}
if ( key === "disabled" && value && this.xhr ) {
this.xhr.abort();
Expand Down
4 changes: 2 additions & 2 deletions ui/jquery.ui.button.js
Expand Up @@ -174,7 +174,7 @@ $.widget( "ui.button", {
}
$( this ).addClass( "ui-state-active" );
lastActive = this;
$( document ).one( "mouseup", function() {
self.document.one( "mouseup", function() {
lastActive = null;
});
})
Expand Down Expand Up @@ -319,7 +319,7 @@ $.widget( "ui.button", {
return;
}
var buttonElement = this.buttonElement.removeClass( typeClasses ),
buttonText = $( "<span></span>", this.element[0].ownerDocument )
buttonText = $( "<span></span>", this.document[0] )
.addClass( "ui-button-text" )
.html( this.options.label )
.appendTo( buttonElement.empty() )
Expand Down
7 changes: 3 additions & 4 deletions ui/jquery.ui.dialog.js
Expand Up @@ -372,8 +372,7 @@ $.widget("ui.dialog", {

_makeDraggable: function() {
var self = this,
options = self.options,
doc = $( document );
options = self.options;

function filteredUi( ui ) {
return {
Expand All @@ -396,8 +395,8 @@ $.widget("ui.dialog", {
},
stop: function( event, ui ) {
options.position = [
ui.position.left - doc.scrollLeft(),
ui.position.top - doc.scrollTop()
ui.position.left - self.document.scrollLeft(),
ui.position.top - self.document.scrollTop()
];
$( this )
.removeClass( "ui-dialog-dragging" );
Expand Down
4 changes: 2 additions & 2 deletions ui/jquery.ui.menu.js
Expand Up @@ -85,7 +85,7 @@ $.widget( "ui.menu", {
},
blur: function( event ) {
this._delay( function() {
if ( ! $.contains( this.element[0], document.activeElement ) ) {
if ( ! $.contains( this.element[0], this.document[0].activeElement ) ) {
this.collapseAll( event );
}
}, 0);
Expand Down Expand Up @@ -207,7 +207,7 @@ $.widget( "ui.menu", {
}
});

this._bind( document, {
this._bind( this.document, {
click: function( event ) {
if ( !$( event.target ).closest( ".ui-menu" ).length ) {
this.collapseAll( event );
Expand Down
2 changes: 1 addition & 1 deletion ui/jquery.ui.popup.js
Expand Up @@ -187,7 +187,7 @@ $.widget( "ui.popup", {
}
});

this._bind(document, {
this._bind( this.document, {
click: function( event ) {
if ( this.isOpen && !$( event.target ).closest( this.element.add( this.options.trigger ) ).length ) {
this.close( event );
Expand Down
4 changes: 2 additions & 2 deletions ui/jquery.ui.spinner.js
Expand Up @@ -53,7 +53,7 @@ $.widget( "ui.spinner", {
// turning off autocomplete prevents the browser from remembering the
// value when navigating through history, so we re-enable autocomplete
// if the page is unloaded before the widget is destroyed. #7790
this._bind( this.element[0].ownerDocument.defaultView, {
this._bind( this.window, {
beforeunload: function() {
this.element.removeAttr( "autocomplete" );
}
Expand Down Expand Up @@ -112,7 +112,7 @@ $.widget( "ui.spinner", {
"mousedown .ui-spinner-button": function( event ) {
// ensure focus is on (or stays on) the text field
event.preventDefault();
if ( document.activeElement !== this.element[ 0 ] ) {
if ( this.document[0].activeElement !== this.element[ 0 ] ) {
this.element.focus();
}

Expand Down
4 changes: 2 additions & 2 deletions ui/jquery.ui.tooltip.js
Expand Up @@ -166,7 +166,7 @@ $.widget( "ui.tooltip", {

// don't close if the element has focus
// this prevents the tooltip from closing if you hover while focused
if ( !force && document.activeElement === target[0] ) {
if ( !force && this.document[0].activeElement === target[0] ) {
return;
}

Expand Down Expand Up @@ -200,7 +200,7 @@ $.widget( "ui.tooltip", {
$( "<div>" )
.addClass( "ui-tooltip-content" )
.appendTo( tooltip );
tooltip.appendTo( document.body );
tooltip.appendTo( this.document[0].body );
if ( $.fn.bgiframe ) {
tooltip.bgiframe();
}
Expand Down
2 changes: 2 additions & 0 deletions ui/jquery.ui.widget.js
Expand Up @@ -195,6 +195,8 @@ $.Widget.prototype = {
if ( element !== this ) {
$.data( element, this.widgetName, this );
this._bind({ remove: "destroy" });
this.document = $( element.ownerDocument );
this.window = $( this.document[0].defaultView );
}

this._create();
Expand Down

0 comments on commit a0856ef

Please sign in to comment.