Skip to content

Commit

Permalink
Fix 'this.options is undefined' in sortable by using this instead of …
Browse files Browse the repository at this point in the history 
…self
  • Loading branch information
@ornicar @scottgonzalez
ornicar authored and scottgonzalez committed May 5, 2010
1 parent 0ad5ac7 commit a4488af
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ui/jquery.ui.sortable.js
View file
Expand Up @@ -81,7 +81,7 @@ $.widget("ui.sortable", $.ui.mouse, {
[ value ? "addClass" : "removeClass"]( "ui-sortable-disabled" );
} else {
// Don't call widget base _setOption for disable as it adds ui-state-disabled class
$.Widget.prototype._setOption.apply(self, arguments);
$.Widget.prototype._setOption.apply(this, arguments);
}
},

Expand Down

5 comments on commit a4488af

@andyshora
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work guys, this bug had me for a while!

@lachlanhardy
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance we can get 1.8.2 released to include this soon?

@scottgonzalez
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ornicar Can you please sign our CLA?

@ornicar
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay done... I grant jQuery the rights over these four characters 🔨

@scottgonzalez
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Please sign in to comment.