Skip to content

Commit

Permalink
Button: Strange space between buttons in IE 7. Fixed #5253 - Toolbar …
Browse files Browse the repository at this point in the history 
…demo ugly in IE
  • Loading branch information
@mikesherov
Pawel Maruszczyk authored and mikesherov committed Nov 28, 2012
1 parent f285440 commit e77edc6
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
7 changes: 6 additions & 1 deletion demos/button/toolbar.html
View file
Expand Up @@ -11,7 +11,12 @@
<link rel="stylesheet" href="../demos.css">
<style>
#toolbar {
padding: 10px 4px;
padding: 11px 4px 9px 4px;
}

/* support: IE7 */
*:first-child+html #toolbar {
padding: 4px 0px 4px 5px;
}
</style>
<script>
Expand Down
2 changes: 1 addition & 1 deletion themes/base/jquery.ui.button.css
View file
Expand Up @@ -42,7 +42,7 @@ button.ui-button-icons-only {

/* button text element */
.ui-button .ui-button-text {
display: block;
display: inline-block;

This comment has been minimized.

Sign in to view

Copy link
@selfthinker

selfthinker Nov 29, 2012

Contributor

This makes <button> texts go across several lines in IE7. E.g. the default button demo shows "A", "button" and "element" on separate lines within the button.
line-height: 1.4;
}
.ui-button-text-only .ui-button-text {
Expand Down
1 change: 1 addition & 0 deletions themes/base/jquery.ui.theme.css
View file
Expand Up @@ -41,6 +41,7 @@
background: #cccccc/*{bgColorHeader}*/ url(images/ui-bg_highlight-soft_75_cccccc_1x100.png)/*{bgImgUrlHeader}*/ 50%/*{bgHeaderXPos}*/ 50%/*{bgHeaderYPos}*/ repeat-x/*{bgHeaderRepeat}*/;
color: #222222/*{fcHeader}*/;
font-weight: bold;
zoom: 1;
}
.ui-widget-header a { color: #222222/*{fcHeader}*/; }

Expand Down

1 comment on commit e77edc6

@selfthinker
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole commit tries to fix the issue in the core, while it really is in the demo. I reverted most of it and fixed the demo issue in #852. (The original issue is really that the #toolbar is a span and not a div. But I didn't change that as I wasn't sure why that is.)

Please sign in to comment.