Make sure we use detach instead of remove in replaceWith. Fixes #5785.

jquery · Jan 11, 2010 · 36a98b9 · 36a98b9
1 parent 366039a
commit 36a98b9
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/src/manipulation.js b/src/manipulation.js
@@ -216,7 +216,7 @@ jQuery.fn.extend({
 			return this.each(function() {
 				var next = this.nextSibling, parent = this.parentNode;
 
-				jQuery(this).remove();
+				jQuery(this).detach();
 
 				if ( next ) {
 					jQuery(next).before( value );

diff --git a/test/unit/manipulation.js b/test/unit/manipulation.js
@@ -626,7 +626,7 @@ test("insertAfter(String|Element|Array&lt;Element&gt;|jQuery)", function() {
 });
 
 var testReplaceWith = function(val) {
-	expect(14);
+	expect(16);
 	jQuery('#yahoo').replaceWith(val( '<b id="replace">buga</b>' ));
 	ok( jQuery("#replace")[0], 'Replace element with string' );
 	ok( !jQuery("#yahoo")[0], 'Verify that original element is gone, after string' );
@@ -648,6 +648,15 @@ var testReplaceWith = function(val) {
 	ok( jQuery("#mark")[0], 'Replace element with set of elements' );
 	ok( !jQuery("#yahoo")[0], 'Verify that original element is gone, after set of elements' );
 
+	reset();
+	var tmp = jQuery("<div/>").appendTo("body").click(function(){ ok(true, "Newly bound click run." ); });
+	var y = jQuery('#yahoo').click(function(){ ok(true, "Previously bound click run." ); });
+	y.replaceWith( tmp );
+	tmp.click();
+	y.click();
+
+	reset();
+
 	var set = jQuery("<div/>").replaceWith(val("<span>test</span>"));
 	equals( set[0].nodeName.toLowerCase(), "span", "Replace the disconnected node." );
 	equals( set.length, 1, "Replace the disconnected node." );