jquery core: Simplifying isEmptyObject() and adding tests.

jquery · Jul 16, 2009 · a38a5cd · a38a5cd
1 parent 991d039
commit a38a5cd
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/src/core.js b/src/core.js
@@ -292,9 +292,9 @@ jQuery.extend({
 	},
 
 	isEmptyObject: function( obj ) {
-		var name = "";
-		for(name in obj) break;
-		return !name;
+		for(var name in obj)
+			return false;
+		return true;
 	},
 
 	// check if an element is in a (or is an) XML document

diff --git a/test/unit/core.js b/test/unit/core.js
@@ -599,3 +599,13 @@ test("jQuery.makeArray", function(){
 
 	ok( jQuery.makeArray(document.getElementById('form')).length >= 13, "Pass makeArray a form (treat as elements)" );
 });
+
+test("jQuery.isEmptyObject", function(){
+	expect(2);
+
+	equals(true, jQuery.isEmptyObject({}), "isEmptyObject on empty object literal" );
+	equals(false, jQuery.isEmptyObject({a:1}), "isEmptyObject on non-empty object literal" );
+
+	// What about this ?
+	// equals(true, jQuery.isEmptyObject(null), "isEmptyObject on null" );
+});