Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#7279 - .bind("ready") events fire out of order #80

Closed
wants to merge 6 commits into from
Closed

#7279 - .bind("ready") events fire out of order #80

wants to merge 6 commits into from

Commits on Oct 30, 2010

  1. Added DOM ready unit tests based on my understanding of how DOM ready… 

    … should work
    @cowboy
    cowboy committed Oct 30, 2010
    Copy the full SHA
    e97a933 View commit details
    Browse the repository at this point in the history

  2. DOM ready handlers bound with jQuery(document).bind( 'ready', fn ) wi… 

    …ll now execute (and unbind) immediately if jQuery.isReady is true
    @cowboy
    cowboy committed Oct 30, 2010
    Copy the full SHA
    638e57f View commit details
    Browse the repository at this point in the history

  3. Binding a handler to DOM ready now utilizes the events system first, … 

    …if possible. This ensures that ready event handlers execute in the proper order, regardless of how they are bound. Handlers bound via jQuery(document).bind( 'ready', fn ) will still have the event object passed in, while handlers bound via jQuery( fn ) and jQuery(document).ready( fn ) will still have a reference to jQuery passed in.
    @cowboy
    cowboy committed Oct 30, 2010
    Copy the full SHA
    14584f3 View commit details
    Browse the repository at this point in the history

  4. Crockford yelled at me, so I removed an unecessary semicolon

    @cowboy
    cowboy committed Oct 30, 2010
    Copy the full SHA
    190084e View commit details
    Browse the repository at this point in the history

  5. removed extraneous console.log

    @cowboy
    cowboy committed Oct 30, 2010
    Copy the full SHA
    012247c View commit details
    Browse the repository at this point in the history

  6. tweaked unit tests to be a little more thorough, tweaked event logic … 

    …to pass in a proper jQuery event object in the case of jQuery(document).bind( 'ready', fn ) being called after DOM ready. This solution can't be as full-featured as if trigger were called, but it should work well enough until the whole DOM ready sub-structure can be re-written.
    @cowboy
    cowboy committed Oct 30, 2010
    Copy the full SHA
    c85f13f View commit details
    Browse the repository at this point in the history