Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the expose mask work properly if you call load while it's closing #1004

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

SudoMike
Copy link

No description provided.

@SudoMike
Copy link
Author

Note: This is to fix a bug where the expose mask will not be there if you have one overlay up and you close that one and load another one. Like this:

$( "#overlay1" ).load();

.. later, in response to a button in overlay1:

$( "#overlay1" ).close();
$( "#overlay2" ).load();

The old behavior was that there would be no expose mask when overlay2 showed up. With this change, the expose mask stops its fadeOut animation when overlay2's load is called.

@alibby251
Copy link
Contributor

Hi SudoMike,

Any chance you could please post a demo with patched code, so we can see this in action please?

@SudoMike
Copy link
Author

Sure. Here's a demo of the bug with the current jquery tools: http://jsfiddle.net/DkwSD/

The meat of the code is in ShowPopup2(), where it hides the first popup and shows the second popup.

Here's the same demo with my fixes: http://jsfiddle.net/v8bjW/3/

The only difference in the second demo is that I've replaced "<script src="http://cdn.jquerytools.org/1.2.7/full/jquery.tools.min.js">" by pasting (the fixed version of) toolbox.expose.js and overlay.js directly in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants