Add strong touch event handling for scrollable.js #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use changedTouches instead of touches. Determine if moves are vertical or horizontal. Ignore horizontal moves on vertical scrollable, respectively vertical moves on horizontal scrollable (this allow the user to scroll the page on horizontal scrollable). Do not scroll on tiny moves. Tested successfully on Android default browser, Chrome mobile and Safari mobile. Firefox should be ok. @see jquerytools#711
I was not so happy with the previous version.
Just reverse prev and next call on vertical scrollable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use changedTouches instead of touches.
Determine if moves are vertical or horizontal.
Ignore horizontal moves on vertical scrollable, respectively vertical moves on horizontal scrollable (this allow the user to scroll the page on horizontal scrollable).
Do not scroll on tiny moves.
Tested successfully on Android default browser, Chrome mobile and Safari mobile. Firefox should be ok.
@see #711