Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for regressions from recent optimizations #8190

Closed
wants to merge 1 commit into from

Conversation

headius
Copy link
Member

@headius headius commented Apr 5, 2024

There are a few regressions that snuck in from recent optimization work (#8170 #8172 #8176 #8177 #8180). This PR will fix them.

@headius headius added this to the JRuby 10.0.0.0 milestone Apr 5, 2024
These names will leak out in stack traces so may need to be
reconsidered.
@headius
Copy link
Member Author

headius commented May 28, 2024

This is invalid now. I reverted some of the changes made and limited the __method__ and __callee__ optimization to method scopes, which avoids the problematic places where different frame name and stack name are being passed. That still needs to be investigated and fixed but this narrows the scope of the optimization to known good paths.

@headius
Copy link
Member Author

headius commented May 28, 2024

#8227

@headius headius deleted the optz_regression_fixes branch May 28, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant