Skip to content
This repository has been archived by the owner on Sep 19, 2019. It is now read-only.

✨ Add create and retrieve methods for Source entry #7

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

✨ Add create and retrieve methods for Source entry #7

wants to merge 4 commits into from

Conversation

esemi
Copy link

@esemi esemi commented Nov 30, 2018

No description provided.

@jsbronder
Copy link
Owner

A few notes:

  • This needs an addition of a class Source so that convert_json_response and create_json_request can do their serialization tasks.
  • Unittests ;)
  • I'd leave out the close method. The intent of the class is that it will borrow a session, not own one. The caller should be closing when appropriate.

@esemi
Copy link
Author

esemi commented Dec 6, 2018

  • Added tests
  • Remove close method
  • Add Source class
  • Add version param for Client

@esemi
Copy link
Author

esemi commented Dec 17, 2018

Hey guy, was up ?)

@jsbronder
Copy link
Owner

It'll be a little bit for me to get to this, my wife gave birth to our son earlier this week :)

@esemi
Copy link
Author

esemi commented Dec 20, 2018

Congratulations! =)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants