Fixed minor "bug" where stopAuto() doesn't work while carousel is animating

[BradBuckingham]

Hi Jan,

I'm not sure if this is a "bug" or not, but I've updated the jcarousel so that stopAuto() works as expected (at least how I expect it to work) when called while the carousel is animating. Let me know what you think.

Thanks,
Brad

[BradBuckingham]

Minor "oops", I forgot to remove a call to "console.log" on line 454. Sorry!

[jsor]

Hi,

maybe its just to early in the morning, but could you explain it a little bit more. I don't get what the changes actually fix.

Thanks, Jan

[BradBuckingham]

Sure,

You can see the "bug" in one of the examples on your site (http://sorgalla.com/projects/jcarousel/examples/static_auto.html)

To replicate: mouseover an image while they are moving (this is a bit tricky because the images move so quickly, but it isn't that hard to do). Leave your mouse over the image and you'll see that the autoscrolling continues despite the fact that your mouse is currently hovering over an image.

Does this make sense?

Brad

[jsor]

Fix stopAuto() not stopping while in animation (Closed by 9d0390e). Fix based on report by Brad Buckingham, http://github.com/jsor/jcarousel/pull/49

[jsor]

Thanks for the report, i got it :)
I hope you don't mind that i didn't applied your patches but fixed it myself in a simpler way.

Thanks, Jan

[BradBuckingham]

Jan,

That's fine with me - I had thought that you'd know how to write the fix better than me anyway. I wrote the patch so that the carousel would work just for me without thinking about all other possible configurations.

Thanks,
Brad

[BorisCarvajal]

I'm looking here trying to solve an issue related to this report.
stopAuto() only gets executed/works between the carousel animations, never while the animation is running. I think the expected behavior is the carousel immediately stops scrolling.

Regards,
Boris

[jsor]

No, it does not stop the animation. It only stops autoscrolling, thus the name stopAuto.