add login_hint as method to identify end-user in signOut #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+312
to
+313
| if ($this->getState() == "") | ||
| $this->setState($_REQUEST['state']); |
There was a problem hiding this comment.
This happens when the session does not contain the state.
Does this introduce security issues?
It looks to me that it is now possible to reload the page with the ?code=<somecode>&state=<some state>. Instead that it was normally not possible because the state was unset.
Maybe the specs says something about this?
There was a problem hiding this comment.
We should for sure not do this - if the session does not hold the necessary values there is something broken.
Same for the nonce below
…ric_prefix) of type string is deprecated
DeepDiver1975
requested changes
Nov 8, 2023
Comment on lines
+312
to
+313
| if ($this->getState() == "") | ||
| $this->setState($_REQUEST['state']); |
There was a problem hiding this comment.
We should for sure not do this - if the session does not hold the necessary values there is something broken.
Same for the nonce below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some identity manager like as Keycloak doesn't support login_hint_token to identifying the end-user. I add "login_hint" method in signOut() function