-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic conversion from integral types to byte array #742
Conversation
src/main/java/org/junitpioneer/jupiter/params/IntegralToBytesConverter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/junitpioneer/jupiter/params/IntegralToBytesConverter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/junitpioneer/jupiter/params/IntegralToBytesConversion.java
Outdated
Show resolved
Hide resolved
src/main/java/org/junitpioneer/jupiter/params/IntegralToBytesConversion.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and thanks again, @Michael1993!
src/main/java/org/junitpioneer/jupiter/converter/ByteArrayArgumentConverter.java
Outdated
Show resolved
Hide resolved
src/test/java/org/junitpioneer/jupiter/converter/ByteArrayConversionTests.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Michael1993, sorry, I'm a little late to provide feedback. I have only one cosmetic point for the user guide.
@@ -0,0 +1,34 @@ | |||
:page-title: Convert Number Argument to Byte Array | |||
:page-description: The JUnit 5 (Jupiter) extension `@NumberToByteArrayConversion` convert the number value of an argument to its byte array representation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about argument converter
instead of extension
?
I'm wondering about the terminology clash with Extension
.
Applies also to other sentences in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superseded by #751.
Proposed commit message:
PR checklist
The following checklist shall help the PR's author, the reviewers and maintainers to ensure the quality of this project.
It is based on our contributors guidelines, especially the "writing code" section.
It shall help to check for completion of the listed points.
If a point does not apply to the given PR's changes, the corresponding entry can be simply marked as done.
Documentation (general)
.adoc
file in thedocs
folder, e.g.docs/report-entries.adoc
.adoc
file references demo insrc/demo/java
instead of containing code blocks as text.adoc
files)Documentation (new extension)
docs/docs-nav.yml
navigation has an entry for the new extensionpackage-info.java
contains information about the new extensionCode
Contributing