feat(connector): [MIFINITY] Implement payment flows and Mifinity payment method #4592

swangi-kumari · 2024-05-08T13:49:27Z

Type of Change

Description

Implement Payments and PSync flows for Mifinity connector.
Implement Mifinity Payment Method.

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Create a Merchant

{
  "merchant_id": "merchant_{{$timestamp}}",
  "locker_id": "m0010",
  "merchant_name": "NewAge Retailer",
  "merchant_details": {
    "primary_contact_person": "John Test",
    "primary_email": "JohnTest@test.com",
    "primary_phone": "sunt laborum",
    "secondary_contact_person": "John Test2",
    "secondary_email": "JohnTest2@test.com",
    "secondary_phone": "cillum do dolor id",
    "website": "https://www.example.com",
    "about_business": "Online Retail with a wide selection of organic products for North America",
    "address": {
      "line1": "1467",
      "line2": "Harrison Street",
      "line3": "Harrison Street",
      "city": "San Fransico",
      "state": "California",
      "zip": "94122",
      "country": "US"
    }
  },
  "return_url": "https://google.com/success",
  "webhook_details": {
    "webhook_version": "1.0.1",
    "webhook_username": "ekart_retail",
    "webhook_password": "password_ekart@123",
    "payment_created_enabled": true,
    "payment_succeeded_enabled": true,
    "payment_failed_enabled": true
  },
  "sub_merchants_enabled": false,
  "metadata": {
    "city": "NY",
    "unit": "245"
  },
  "primary_business_details": [
    {
      "country": "US",
      "business": "food"
    }
  ]
}

Create API Key

{
  "name": "API Key 1",
  "description": null,
  "expiration": "2038-01-19T03:14:08.000Z"
}

Payment Connector Create

{
    "connector_type": "fiz_operations",
    "connector_name": "mifinity",
    "connector_account_details": {
        "auth_type": "HeaderKey",
        "api_key": "{______}"
    },
    "test_mode": false,
    "disabled": false,
    "payment_methods_enabled": [
                 {
            "payment_method": "wallet",
            "payment_method_types": [
                {
                    "payment_method_type": "mifinity",
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                }
            ]
        }
    ],
    "metadata": {
        "city": "NY",
        "unit": "245",
        "brand_id": "001"
    },
    "business_country": "US",
    "business_label": "food"
}

Create a Mifinity Wallet Payment via Mifinity

    "amount": 1000,
    "currency": "EUR",
    "confirm": true,
      "capture_method": "automatic",
      "capture_on": "2022-09-10T10:11:12Z",
      "amount_to_capture": 1000,
    "customer_id": "StripeCustomer",
    "email": "guest@example.com",
    "name": "John Doe",
    "phone": "999999999",
    "phone_country_code": "+1",
    "description": "Its my first payment request",
      "authentication_type": "no_three_ds",
    "return_url": "https://www.google.com/",
    "payment_method": "wallet",
    "payment_method_type": "mifinity",
    "payment_method_data": {
        "wallet": {
            "mifinity": {
                "destination_account_number": "5001000001223369",
                "dob": "2001-10-16"
            }
        }
    },
    "billing": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "DE",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        },
        "email": "swangi@gmail.com"
    },
    "shipping": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "DE",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        }
    },
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "metadata": {
        "udf1": "value1",
        "new_customer": "true",
        "login_date": "2019-09-10T10:11:12Z"
    }
    // "business_label": "food", 
    // "business_country": "US",
    // "profile_id": "pro_vsFxMOhOqXt4FMYjVral"
}

Response

Using redirection_url in response complete the payment

{
    "payment_id": "pay_QoGz4Pu98CFsMxtT5HWZ",
    "merchant_id": "merchant_1716269219",
    "status": "requires_customer_action",
    "amount": 1000,
    "net_amount": 1000,
    "amount_capturable": 1000,
    "amount_received": null,
    "connector": "mifinity",
    "client_secret": "pay_QoGz4Pu98CFsMxtT5HWZ_secret_2cbvKwEt2LffCDYhFIgQ",
    "created": "2024-05-21T05:43:12.607Z",
    "currency": "EUR",
    "customer_id": "StripeCustomer",
    "customer": {
        "id": "StripeCustomer",
        "name": "John Doe",
        "email": "guest@example.com",
        "phone": "999999999",
        "phone_country_code": "+1"
    },
    "description": "Its my first payment request",
    "refunds": null,
    "disputes": null,
    "mandate_id": null,
    "mandate_data": null,
    "setup_future_usage": null,
    "off_session": null,
    "capture_on": null,
    "capture_method": "automatic",
    "payment_method": "wallet",
    "payment_method_data": {
        "wallet": {},
        "billing": null
    },
    "payment_token": null,
    "shipping": {
        "address": {
            "city": "San Fransico",
            "country": "DE",
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "zip": "94122",
            "state": "California",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        },
        "email": null
    },
    "billing": {
        "address": {
            "city": "San Fransico",
            "country": "DE",
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "zip": "94122",
            "state": "California",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        },
        "email": "swangi@gmail.com"
    },
    "order_details": null,
    "email": "guest@example.com",
    "name": "John Doe",
    "phone": "999999999",
    "return_url": "https://www.google.com/",
    "authentication_type": "no_three_ds",
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "next_action": {
        "type": "redirect_to_url",
        "redirect_to_url": "http://localhost:8080/payments/redirect/pay_QoGz4Pu98CFsMxtT5HWZ/merchant_1716269219/pay_QoGz4Pu98CFsMxtT5HWZ_1"
    },
    "cancellation_reason": null,
    "error_code": null,
    "error_message": null,
    "unified_code": null,
    "unified_message": null,
    "payment_experience": null,
    "payment_method_type": "mifinity",
    "connector_label": null,
    "business_country": null,
    "business_label": "default",
    "business_sub_label": null,
    "allowed_payment_method_types": null,
    "ephemeral_key": {
        "customer_id": "StripeCustomer",
        "created_at": 1716270192,
        "expires": 1716273792,
        "secret": "epk_91cebf4aba1241c0be573e5bd807b070"
    },
    "manual_retry_allowed": null,
    "connector_transaction_id": "pay_QoGz4Pu98CFsMxtT5HWZ_1",
    "frm_message": null,
    "metadata": {
        "udf1": "value1",
        "login_date": "2019-09-10T10:11:12Z",
        "new_customer": "true"
    },
    "connector_metadata": null,
    "feature_metadata": null,
    "reference_id": "pay_QoGz4Pu98CFsMxtT5HWZ_1",
    "payment_link": null,
    "profile_id": "pro_HqWDRNDr8bL3Wi7Z5wIN",
    "surcharge_details": null,
    "attempt_count": 1,
    "merchant_decision": null,
    "merchant_connector_id": "mca_RkJnWGLzO9fDEYXEP1cb",
    "incremental_authorization_allowed": null,
    "authorization_count": null,
    "incremental_authorizations": null,
    "external_authentication_details": null,
    "external_3ds_authentication_attempted": false,
    "expires_on": "2024-05-21T05:58:12.607Z",
    "fingerprint": null,
    "browser_info": null,
    "payment_method_id": null,
    "payment_method_status": null,
    "updated": "2024-05-21T05:43:13.983Z",
    "frm_metadata": null
}

do a PSync with same payment_id

Response

{
    "payment_id": "pay_QoGz4Pu98CFsMxtT5HWZ",
    "merchant_id": "merchant_1716269219",
    "status": "succeeded",
    "amount": 1000,
    "net_amount": 1000,
    "amount_capturable": 0,
    "amount_received": 1000,
    "connector": "mifinity",
    "client_secret": "pay_QoGz4Pu98CFsMxtT5HWZ_secret_2cbvKwEt2LffCDYhFIgQ",
    "created": "2024-05-21T05:43:12.607Z",
    "currency": "EUR",
    "customer_id": "StripeCustomer",
    "customer": {
        "id": "StripeCustomer",
        "name": "John Doe",
        "email": "guest@example.com",
        "phone": "999999999",
        "phone_country_code": "+1"
    },
    "description": "Its my first payment request",
    "refunds": null,
    "disputes": null,
    "mandate_id": null,
    "mandate_data": null,
    "setup_future_usage": null,
    "off_session": null,
    "capture_on": null,
    "capture_method": "automatic",
    "payment_method": "wallet",
    "payment_method_data": {
        "wallet": {},
        "billing": null
    },
    "payment_token": null,
    "shipping": {
        "address": {
            "city": "San Fransico",
            "country": "DE",
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "zip": "94122",
            "state": "California",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        },
        "email": null
    },
    "billing": {
        "address": {
            "city": "San Fransico",
            "country": "DE",
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "zip": "94122",
            "state": "California",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        },
        "email": "swangi@gmail.com"
    },
    "order_details": null,
    "email": "guest@example.com",
    "name": "John Doe",
    "phone": "999999999",
    "return_url": "https://www.google.com/",
    "authentication_type": "no_three_ds",
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "next_action": null,
    "cancellation_reason": null,
    "error_code": null,
    "error_message": null,
    "unified_code": null,
    "unified_message": null,
    "payment_experience": null,
    "payment_method_type": "mifinity",
    "connector_label": null,
    "business_country": null,
    "business_label": "default",
    "business_sub_label": null,
    "allowed_payment_method_types": null,
    "ephemeral_key": null,
    "manual_retry_allowed": false,
    "connector_transaction_id": "aea08e48-68cb-44f3-8fca-c3c5c659700c",
    "frm_message": null,
    "metadata": {
        "udf1": "value1",
        "login_date": "2019-09-10T10:11:12Z",
        "new_customer": "true"
    },
    "connector_metadata": null,
    "feature_metadata": null,
    "reference_id": "pay_QoGz4Pu98CFsMxtT5HWZ_1",
    "payment_link": null,
    "profile_id": "pro_HqWDRNDr8bL3Wi7Z5wIN",
    "surcharge_details": null,
    "attempt_count": 1,
    "merchant_decision": null,
    "merchant_connector_id": "mca_RkJnWGLzO9fDEYXEP1cb",
    "incremental_authorization_allowed": null,
    "authorization_count": null,
    "incremental_authorizations": null,
    "external_authentication_details": null,
    "external_3ds_authentication_attempted": false,
    "expires_on": "2024-05-21T05:58:12.607Z",
    "fingerprint": null,
    "browser_info": null,
    "payment_method_id": null,
    "payment_method_status": null,
    "updated": "2024-05-21T05:47:52.254Z",
    "frm_metadata": null
}

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

…into mifinity-impl

srujanchikke · 2024-05-22T12:17:44Z

crates/router/src/core/admin.rs

@@ -1949,6 +1949,10 @@ pub(crate) fn validate_auth_and_metadata_type(
            klarna::transformers::KlarnaAuthType::try_from(val)?;
            Ok(())
        }
+        api_enums::Connector::Mifinity => {
+            mifinity::transformers::MifinityAuthType::try_from(val)?;


Suggested change

mifinity::transformers::MifinityAuthType::try_from(val)?;

mifinity::transformers::MifinityAuthType::try_from(val)?;

mifinity::transformers::MifinityConnectorMetadataObject::try_from(connector_meta_data)?;

srujanchikke · 2024-05-22T12:19:20Z

crates/router/src/connector/mifinity/transformers.rs

+#[serde(rename_all = "SCREAMING_SNAKE_CASE")]
+pub enum MifinityPaymentStatus {
+    Successful,
+    #[default]


default should not be implemented for payment status

srujanchikke · 2024-05-22T13:18:14Z

crates/router/src/connector/mifinity/transformers.rs

-                refund_status: enums::RefundStatus::from(item.response.status),
+            status: enums::AttemptStatus::from(status),
+            response: Ok(types::PaymentsResponseData::TransactionResponse {
+                resource_id: types::ResponseId::ConnectorTransactionId(transaction_reference),


instead of collecting all the reference_id, just take the first one.

srujanchikke · 2024-05-22T13:19:07Z

crates/router/src/connector/mifinity/transformers.rs

            }
-            _ => Err(errors::ConnectorError::NotImplemented("Payment methods".to_string()).into()),
        }
    }
 }

 //TODO: Fill the struct with respective fields


remove todo's

srujanchikke · 2024-05-22T13:20:00Z

crates/router/src/connector/mifinity/transformers.rs

+    dialing_code: String,
+    nationality: api_models::enums::CountryAlpha2,
+    email_address: Email,
+    dob: Secret<Date>,
 }

 #[derive(Default, Debug, Serialize, Eq, PartialEq)]


do we need all the derives ?

swangi-kumari and others added 8 commits April 24, 2024 11:42

refactor: add template code for mifinity

c492f98

docs(openapi): re-generate OpenAPI specification

c7a161b

Merge branch 'main' into mifinity-template-code

1b75cee

refactor: fix

90c4bd8

docs(openapi): re-generate OpenAPI specification

21b4c61

Merge branch 'main' into mifinity-template-code

9712441

feat: implement mifinity

87ba8dd

Merge branch 'main' into mifinity-impl

8ffb2a4

swangi-kumari added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement labels May 8, 2024

swangi-kumari self-assigned this May 8, 2024

swangi-kumari and others added 15 commits May 9, 2024 12:12

Merge branch 'main' into mifinity-impl

6cccbf2

refactor: payments

54a5703

Merge branch 'main' into mifinity-impl

120320a

feat: payments and sync

5631bac

refactor: transaction_reference in psync

6d5004f

chore: run formatter

61544a9

refactor: add brand_id for mifinity in metadata

bc9924e

Merge branch 'mifinity-impl' of https://github.com/juspay/hyperswitch …

78fdc58

…into mifinity-impl

refactor: solve clippy

4abddb7

Merge branch 'main' into mifinity-impl

d547e85

refactor: clippy

8690792

refactor: add dependency to support Date

e746994

time dependency added

9b2f176

chore: run formatter

c4b75c5

transfermer status update

e3eab66

KiranKBR force-pushed the mifinity-impl branch from c4b75c5 to e3eab66 Compare May 20, 2024 15:21

swangi-kumari and others added 3 commits May 20, 2024 21:46

Merge branch 'mifinity-impl' of https://github.com/juspay/hyperswitch …

b597beb

…into mifinity-impl

refactor: resolve clippy

e3e502b

feature enabled serde-human-readable

4cc284d

swangi-kumari marked this pull request as ready for review May 21, 2024 07:31

swangi-kumari requested review from a team as code owners May 21, 2024 07:31

swangi-kumari added 7 commits May 21, 2024 15:11

refactor: resolve clippy

a424a3f

Merge branch 'mifinity-impl' of https://github.com/juspay/hyperswitch …

7f12a42

…into mifinity-impl

refactor: opdate openapi

dadb522

refactor: fix openapi

374c9e8

Merge branch 'main' into mifinity-impl

c917034

refactor: resolve clippy

7e7753f

refactor: solve open api

35fee25

srujanchikke requested changes May 22, 2024

View reviewed changes

refactor: resolve comments and handle psync for no response scenario

ff6a76c

swangi-kumari requested a review from SamraatBansal May 23, 2024 09:24

swangi-kumari added 2 commits May 23, 2024 18:49

Merge branch 'main' into mifinity-impl

fc9b6e3

refactor: resolve conflicts

0ac186f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(connector): [MIFINITY] Implement payment flows and Mifinity payment method #4592

feat(connector): [MIFINITY] Implement payment flows and Mifinity payment method #4592

swangi-kumari commented May 8, 2024 •

edited

srujanchikke May 22, 2024

srujanchikke May 22, 2024

srujanchikke May 22, 2024

srujanchikke May 22, 2024

srujanchikke May 22, 2024

	mifinity::transformers::MifinityAuthType::try_from(val)?;
	mifinity::transformers::MifinityAuthType::try_from(val)?;
	mifinity::transformers::MifinityConnectorMetadataObject::try_from(connector_meta_data)?;

feat(connector): [MIFINITY] Implement payment flows and Mifinity payment method #4592

Are you sure you want to change the base?

feat(connector): [MIFINITY] Implement payment flows and Mifinity payment method #4592

Conversation

swangi-kumari commented May 8, 2024 • edited

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

srujanchikke May 22, 2024

Choose a reason for hiding this comment

srujanchikke May 22, 2024

Choose a reason for hiding this comment

srujanchikke May 22, 2024

Choose a reason for hiding this comment

srujanchikke May 22, 2024

Choose a reason for hiding this comment

srujanchikke May 22, 2024

Choose a reason for hiding this comment

swangi-kumari commented May 8, 2024 •

edited