Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report K3s Windows] - Command Name for the k3s binary is incomplete in binary_size_check.sh #9991

Closed
ag6221254 opened this issue Apr 22, 2024 · 3 comments
Assignees
Milestone

Comments

@ag6221254
Copy link
Contributor

ag6221254 commented Apr 22, 2024

Environmental Info:
K3s Version:
v1.28.x

Describe the bug:
Command Name for the k3s binary is incomplete in binary_size_check.sh

These are the associated pull request or work items:
#9992

Steps To Reproduce:

Run command -
GOOS=windows CXX=x86_64-w64-mingw32-g++ CC=x86_64-w64-mingw32-gcc SKIP_VALIDATE=true ./scripts/ci

  • Installed K3s: v1.28.3

Expected behavior:

No Error
Actual behavior:
Error - stat: cannot stat 'dist/artifacts/k3s': No such file or directory

Additional context / logs:
None

@mdrahman-suse
Copy link

Validated on master branch with commit b4d4ed8

The error reported was not observed when followed through the build instructions: #9991 (comment)

~/k3s$ GOOS=windows CXX=x86_64-w64-mingw32-g++ CC=x86_64-w64-mingw32-gcc SKIP_VALIDATE=true ./scripts/ci
...
+ ./scripts/build-upload dist/artifacts/k3s.exe b4d4ed8f010a2f95035652bb03565d16a4ddb87f
...

~/k3s$ ls dist/artifacts/
k3s.exe

@ag6221254
Copy link
Contributor Author

@mdrahman-suse - Changes related to this issue has been pushed, not sure which version you tried on but if it is the latest then I guess there is will no error now 👍

@mdrahman-suse
Copy link

@mdrahman-suse - Changes related to this issue has been pushed, not sure which version you tried on but if it is the latest then I guess there is will no error now 👍

Yes I tested with this commit from master b4d4ed8 and I don't see the issue, hence closed it as validated. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants