-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the script binary_size_check to complete the command name by… #9992
Updating the script binary_size_check to complete the command name by… #9992
Conversation
Looking for reviews and approval on the above PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please sign-off your commits for DCO.
Thank you for reviewing. Done with the sign-off. |
You'll need to rebase, squash, sign-off a single commit, and then force-push to the branch. I'm still seeing DCI failure and a merge commit on this branch. |
… adding .exe extension to the k3s binary name to make it available to run stat command Signed-off-by: Anuj Garg <anujgarg@microsoft.com>
d4ee1ba
to
de137d3
Compare
ohh ok. Corrected! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9992 +/- ##
==========================================
- Coverage 50.06% 40.68% -9.38%
==========================================
Files 158 156 -2
Lines 14021 13999 -22
==========================================
- Hits 7019 5696 -1323
- Misses 5672 7137 +1465
+ Partials 1330 1166 -164
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Can I please get 1 more approval ? |
Thank you for the approvals. Can we also please get it merged from the authorized user ? |
No. We are in code freeze for the May patch releases. |
… adding .exe extension to the k3s binary name to make it available to run stat command
Proposed Changes
This is the Modification in K3s agent for Windows port. This pull request is focused on:
Types of Changes
BugFix
Verification
Run GOOS=windows CXX=x86_64-w64-mingw32-g++ CC=x86_64-w64-mingw32-gcc SKIP_VALIDATE=true ./scripts/ci on Ubuntu machine to proof build Windows port.
NOTE: You may need to install the following packages to build:
sudo apt-get install mingw-w64
sudo apt-get install zstd
Testing
We Can follow same testing steps as mentioned in the PR - #7259
Linked Issues
#9991
User-Facing Change
None
Further Comments
None