Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the script binary_size_check to complete the command name by… #9992

Merged
merged 1 commit into from
May 28, 2024

Conversation

ag6221254
Copy link
Contributor

… adding .exe extension to the k3s binary name to make it available to run stat command

Proposed Changes

This is the Modification in K3s agent for Windows port. This pull request is focused on:

  1. Updating the script binary_size_check.sh to complete the command name by adding .exe extension to the k3s binary name to make it available to run stat command

Types of Changes

BugFix

Verification

Run GOOS=windows CXX=x86_64-w64-mingw32-g++ CC=x86_64-w64-mingw32-gcc SKIP_VALIDATE=true ./scripts/ci on Ubuntu machine to proof build Windows port.

NOTE: You may need to install the following packages to build:

sudo apt-get install mingw-w64
sudo apt-get install zstd

Testing

We Can follow same testing steps as mentioned in the PR - #7259

Linked Issues

#9991

User-Facing Change

None


Further Comments

None

@ag6221254
Copy link
Contributor Author

Looking for reviews and approval on the above PR.

Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please sign-off your commits for DCO.

@ag6221254
Copy link
Contributor Author

Thank you for reviewing. Done with the sign-off.

@ag6221254 ag6221254 requested a review from brandond May 7, 2024 05:09
@brandond
Copy link
Member

brandond commented May 7, 2024

You'll need to rebase, squash, sign-off a single commit, and then force-push to the branch. I'm still seeing DCI failure and a merge commit on this branch.

… adding .exe extension to the k3s binary name to make it available to run stat command

Signed-off-by: Anuj Garg <anujgarg@microsoft.com>
@ag6221254 ag6221254 force-pushed the dev/anujgarg/windows_april22 branch from d4ee1ba to de137d3 Compare May 7, 2024 10:27
@ag6221254
Copy link
Contributor Author

ohh ok. Corrected!

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.68%. Comparing base (d3b6054) to head (de137d3).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9992      +/-   ##
==========================================
- Coverage   50.06%   40.68%   -9.38%     
==========================================
  Files         158      156       -2     
  Lines       14021    13999      -22     
==========================================
- Hits         7019     5696    -1323     
- Misses       5672     7137    +1465     
+ Partials     1330     1166     -164     
Flag Coverage Δ
e2etests 36.42% <ø> (-10.16%) ⬇️
inttests 37.11% <ø> (+0.01%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ag6221254
Copy link
Contributor Author

Can I please get 1 more approval ?

@ag6221254
Copy link
Contributor Author

Thank you for the approvals. Can we also please get it merged from the authorized user ?

@brandond
Copy link
Member

No. We are in code freeze for the May patch releases.

@brandond brandond merged commit eb19219 into k3s-io:master May 28, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants