Updating the script binary_size_check to complete the command name by… #9992
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking for reviews and approval on the above PR. |
brandond
approved these changes
May 6, 2024
brandond
requested changes
May 6, 2024
|
Thank you for reviewing. Done with the sign-off. |
|
You'll need to rebase, squash, sign-off a single commit, and then force-push to the branch. I'm still seeing DCI failure and a merge commit on this branch. |
… adding .exe extension to the k3s binary name to make it available to run stat command Signed-off-by: Anuj Garg <anujgarg@microsoft.com>
ag6221254
force-pushed
the
dev/anujgarg/windows_april22
branch
from
d4ee1ba
to
de137d3
Compare
|
ohh ok. Corrected! |
brandond
approved these changes
May 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9992 +/- ##
==========================================
- Coverage 50.06% 40.68% -9.38%
==========================================
Files 158 156 -2
Lines 14021 13999 -22
==========================================
- Hits 7019 5696 -1323
- Misses 5672 7137 +1465
+ Partials 1330 1166 -164
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… adding .exe extension to the k3s binary name to make it available to run stat command
Proposed Changes
This is the Modification in K3s agent for Windows port. This pull request is focused on:
Types of Changes
BugFix
Verification
Run GOOS=windows CXX=x86_64-w64-mingw32-g++ CC=x86_64-w64-mingw32-gcc SKIP_VALIDATE=true ./scripts/ci on Ubuntu machine to proof build Windows port.
NOTE: You may need to install the following packages to build:
sudo apt-get install mingw-w64
sudo apt-get install zstd
Testing
We Can follow same testing steps as mentioned in the PR - #7259
Linked Issues
#9991
User-Facing Change
None
Further Comments
None