-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug: allow helm controller set owner reference #10048
Conversation
Signed-off-by: huangzy <huangzynn@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, LGTM!
- Looks like this was added in Refactor controllers to separate package, shift cli-runtime to wrangler-cli, introduce pprof options helm-controller#157 but missed when we pulled in the refactor in Update helm-controller to pull in refactor #6294
In the future, PLEASE use the PR template, and create an issue to track the defect you are fixing. I'm not sure why you deleted it instead of at least filling out the proposed changes. I've created an issue for this, and copied your text into the template. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10048 +/- ##
==========================================
- Coverage 49.92% 40.69% -9.24%
==========================================
Files 158 155 -3
Lines 14032 13980 -52
==========================================
- Hits 7006 5689 -1317
- Misses 5690 7123 +1433
+ Partials 1336 1168 -168
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Proposed Changes
Allow helm controller set owner reference, when helm controller obj is deleteed , will delete helm-delete-job.
If not set owner reference, the second installation and removal will fail
Reference:
https://github.com/k3s-io/helm-controller/blob/d74a09dfcaefdd6e8bea80d5aac66e70ea4e93d3/pkg/controllers/controllers.go#L144
Types of Changes
bugfix
Verification
See linked issue
Testing
Linked Issues
User-Facing Change
Further Comments