Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: allow helm controller set owner reference #10048

Merged
merged 1 commit into from
May 24, 2024

Conversation

huangzynn
Copy link
Contributor

@huangzynn huangzynn commented Apr 30, 2024

Proposed Changes

Allow helm controller set owner reference, when helm controller obj is deleteed , will delete helm-delete-job.
If not set owner reference, the second installation and removal will fail
Reference:
https://github.com/k3s-io/helm-controller/blob/d74a09dfcaefdd6e8bea80d5aac66e70ea4e93d3/pkg/controllers/controllers.go#L144

Types of Changes

bugfix

Verification

See linked issue

Testing

Linked Issues

User-Facing Change

Further Comments

image

Signed-off-by: huangzy <huangzynn@outlook.com>
@huangzynn huangzynn requested a review from a team as a code owner April 30, 2024 09:25
Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brandond
Copy link
Member

brandond commented Apr 30, 2024

In the future, PLEASE use the PR template, and create an issue to track the defect you are fixing. I'm not sure why you deleted it instead of at least filling out the proposed changes.

I've created an issue for this, and copied your text into the template.

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.69%. Comparing base (0981f00) to head (b2f0f70).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10048      +/-   ##
==========================================
- Coverage   49.92%   40.69%   -9.24%     
==========================================
  Files         158      155       -3     
  Lines       14032    13980      -52     
==========================================
- Hits         7006     5689    -1317     
- Misses       5690     7123    +1433     
+ Partials     1336     1168     -168     
Flag Coverage Δ
e2etests 36.47% <100.00%> (-10.01%) ⬇️
inttests 37.08% <100.00%> (-0.02%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants