Fix bug: allow helm controller set owner reference #10048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: huangzy <huangzynn@outlook.com>
brandond
reviewed
Apr 30, 2024
There was a problem hiding this comment.
Thank you, LGTM!
- Looks like this was added in Refactor controllers to separate package, shift cli-runtime to wrangler-cli, introduce pprof options helm-controller#157 but missed when we pulled in the refactor in Update helm-controller to pull in refactor #6294
|
In the future, PLEASE use the PR template, and create an issue to track the defect you are fixing. I'm not sure why you deleted it instead of at least filling out the proposed changes. I've created an issue for this, and copied your text into the template. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10048 +/- ##
==========================================
- Coverage 49.92% 40.69% -9.24%
==========================================
Files 158 155 -3
Lines 14032 13980 -52
==========================================
- Hits 7006 5689 -1317
- Misses 5690 7123 +1433
+ Partials 1336 1168 -168
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dereknola
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Allow helm controller set owner reference, when helm controller obj is deleteed , will delete helm-delete-job.
If not set owner reference, the second installation and removal will fail
Reference:
https://github.com/k3s-io/helm-controller/blob/d74a09dfcaefdd6e8bea80d5aac66e70ea4e93d3/pkg/controllers/controllers.go#L144
Types of Changes
bugfix
Verification
See linked issue
Testing
Linked Issues
User-Facing Change
Further Comments