Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with externalTrafficPolicy: Local for single-stack services on dual-stack nodes #9963

Merged
merged 1 commit into from
May 23, 2024

Conversation

brandond
Copy link
Member

@brandond brandond commented Apr 17, 2024

Proposed Changes

Fix issue with local traffic policy for single-stack services on dual-stack nodes.

Just enable IP forwarding for all address families regardless of service address families.

Note: I confirmed that this works even on a node with ipv6 disabled via net.ipv6.conf.all.disable_ipv6=1 sysctl.

Types of Changes

bugfix

Verification

#9949 (comment)

Testing

Linked Issues

User-Facing Change


Further Comments

@brandond brandond requested a review from a team as a code owner April 17, 2024 17:44
@brandond brandond changed the title Fix issue with local traffic policy for single-stack services on dual-stack nodes Fix issue with externalTrafficPolicy: Local for single-stack services on dual-stack nodes Apr 17, 2024
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 24.87%. Comparing base (81cd630) to head (6f47182).
Report is 3 commits behind head on master.

Files Patch % Lines
pkg/cloudprovider/servicelb.go 0.00% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9963       +/-   ##
===========================================
- Coverage   49.63%   24.87%   -24.77%     
===========================================
  Files         158      158               
  Lines       14017    14010        -7     
===========================================
- Hits         6958     3485     -3473     
- Misses       5755     9834     +4079     
+ Partials     1304      691      -613     
Flag Coverage Δ
e2etests 4.84% <0.00%> (-41.30%) ⬇️
inttests 18.94% <0.00%> (-18.11%) ⬇️
unittests 16.57% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…-stack nodes.

Just enable IP forwarding for all address families regardless of service address families.

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@damdo
Copy link

damdo commented May 14, 2024

@brandond @manuelbuil is this ready to merge now? Thanks!

@manuelbuil
Copy link
Contributor

@brandond @manuelbuil is this ready to merge now? Thanks!

We are currently on code freeze. We can't merge anything

@damdo
Copy link

damdo commented May 14, 2024

I see @manuelbuil thanks.
My k3s cluster is currently impacted by this issue.
I'd appreciate if this could merge when the code freeze lifts, and whether this could be backported to 1.29.z.
Thanks!

@manuelbuil
Copy link
Contributor

I see @manuelbuil thanks. My k3s cluster is currently impacted by this issue. I'd appreciate if this could merge when the code freeze lifts, and whether this could be backported to 1.29.z. Thanks!

Code freeze is normally lifted around the last week of the month. We will backport to all upstream maintained branches in June (1.29, 1.28 and probably 1.27)

Copy link
Contributor

@matttrach matttrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants