-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with externalTrafficPolicy: Local
for single-stack services on dual-stack nodes
#9963
Conversation
externalTrafficPolicy: Local
for single-stack services on dual-stack nodes
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9963 +/- ##
===========================================
- Coverage 49.63% 24.87% -24.77%
===========================================
Files 158 158
Lines 14017 14010 -7
===========================================
- Hits 6958 3485 -3473
- Misses 5755 9834 +4079
+ Partials 1304 691 -613
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…-stack nodes. Just enable IP forwarding for all address families regardless of service address families. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
b4481f4
to
6f47182
Compare
@brandond @manuelbuil is this ready to merge now? Thanks! |
We are currently on code freeze. We can't merge anything |
I see @manuelbuil thanks. |
Code freeze is normally lifted around the last week of the month. We will backport to all upstream maintained branches in June (1.29, 1.28 and probably 1.27) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Proposed Changes
Fix issue with local traffic policy for single-stack services on dual-stack nodes.
Just enable IP forwarding for all address families regardless of service address families.
Note: I confirmed that this works even on a node with ipv6 disabled via
net.ipv6.conf.all.disable_ipv6=1
sysctl.Types of Changes
bugfix
Verification
#9949 (comment)
Testing
Linked Issues
User-Facing Change
Further Comments