Dealing with symlink pointing to directories (fix #11) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now shell-safe-rm will consider a symlink to a directory like a regular file
in travis environment (or when Trash directory doesn't exist) we need to answer yes when calling shell-safe-rm for the first time
bunop
commented
Mar 31, 2017
| # if is dir and not a symbolick link | ||
| if [[ -d "$file" && ! -L "$file" ]]; then | ||
|
|
||
| # if a directory, and without '-r' option |
There was a problem hiding this comment.
Added one level of indentation: those are clauses evaluated in directory condition
| # up to date and its recipe would not be executed. To avoid this problem you | ||
| # can explicitly declare the target to be phony by making it a prerequisite of | ||
| # the special target | ||
| # TODO: is test directory really needed? |
There was a problem hiding this comment.
I see that there is a testdirectory, but I didn't understand if such code is useful or not. I need to define the .PHONY target rule in order to do tests
|
This will solve #11 |
bunop
changed the title
bunop
changed the title
|
merge for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now shell-safe-rm will consider a symlink to a directory like a regular file; Added indentation in
directorycondition