Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-13857): search is cleared when prevent seek is enabled #187

Merged
merged 2 commits into from Apr 16, 2024

Conversation

lianbenjamin
Copy link
Contributor

@lianbenjamin lianbenjamin commented Apr 15, 2024

the issue:
if searching for a text in transcript and new captions arrived, the search value is being cleared.
only reproduced when preventSeek feature is enabled.

root cause:
when preventSeek feature is enabled, the transcript is receiving new (current) captions from the cue-point service, which causing to re-render the transcript including the search bar.
current implementation is clearing the search value whenever the "old" captions are different from "new" captions, which only happened when captions language was switched - used to work with static data, rather than dynamic.

solution:

  • add a new prop which states the active caption language
  • clear the search value only if the active caption language has changed
  • Also, trigger the search when new captions were added to the transcript for the same language (in order to have results also for the new captions)

Solves FEC-13857

@lianbenjamin lianbenjamin merged commit a44fd29 into master Apr 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants