fix(FEC-13889): Download_close being reported too many times to application events #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 9, 2024
SivanA-Kaltura
approved these changes
May 9, 2024
SivanA-Kaltura
approved these changes
May 9, 2024
JonathanTGold
added a commit
to kaltura/playkit-js-navigation
that referenced
this pull request
May 9, 2024
…cation events (#360) ### Resolves: [FEC-13889](https://kaltura.atlassian.net/browse/FEC-13889) #### Related PRs: kaltura/playkit-js-transcript#192 kaltura/playkit-js-qna#342 kaltura/playkit-js-ui-managers#52 [FEC-13889]: https://kaltura.atlassian.net/browse/FEC-13889?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: JonathanTGold <jonathan.gold@86@gmail.com>
JonathanTGold
added a commit
to kaltura/playkit-js-ui-managers
that referenced
this pull request
May 9, 2024
… & onDecativate callback params from SidePaneItem Interface (#52) ### Description of the Changes Please add a detailed description of the change, whether it's an enhancement or a bugfix. ### Resolves: [FEC-13889](https://kaltura.atlassian.net/browse/FEC-13889) #### Related PRs: kaltura/playkit-js-transcript#192 kaltura/playkit-js-qna#342 kaltura/playkit-js-navigation#360 [FEC-13889]: https://kaltura.atlassian.net/browse/FEC-13889?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: JonathanTGold <jonathan.gold@86@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: FEC-13889
issue:
issue: the
_deactiveItem()(which in turn callsthis.dispatchEvent(TranscriptEvents.TRANSCRIPT_CLOSE)) is called twice , one: on close icon click, second: as a callback from onDeactivate() parm of sidePanels() APIsolution: remove the callback, which is redundant since the
_deactiveItem()is called manualy every time...Related PRs:
kaltura/playkit-js-navigation#360
kaltura/playkit-js-qna#342
kaltura/playkit-js-ui-managers#52