FOUN-1370: add kafka event notification for roomEntry changes #12595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add kafka event notification for roomEntry changes raise event also if it doesn't require any permission
yossipapi
reviewed
Mar 4, 2024
deployment/updates/scripts/2024_03_03_deploy_kafka_room_events.php
Outdated
Show resolved
Hide resolved
yossipapi
reviewed
Mar 4, 2024
deployment/updates/scripts/2024_03_03_deploy_kafka_room_events.php
Outdated
Show resolved
Hide resolved
yossipapi
reviewed
Mar 4, 2024
| @@ -114,7 +114,7 @@ public function dispatch(kScope $scope) | |||
| } | |||
|
|
|||
| $requiredPermissions = explode(",", $this->getRequiresPermissions()); | |||
| if(count($requiredPermissions)) | |||
| if(count(array_filter($requiredPermissions))) | |||
There was a problem hiding this comment.
If the purpose is to remove all empty values that return true on the empty() function please state the function when calling array_filter. To avoid case where this logic will change in the future.
From PHP doc:
callback
The callback function to use
If no callback is supplied, all empty entries of array will be removed. See empty() for how PHP defines empty in this case.
There was a problem hiding this comment.
It isn't possible to pass "empty" to "array_filter" as "empty" is not a function but a language construct
I think I'll use "strlen" which doing the job in our case (the case when $this->getRequiresPermissions() returns null and explode returns array of empty string).
Is it sounds ok for you?
yossipapi
reviewed
Mar 4, 2024
...updates/scripts/xml/notifications/2024_03_03_add_kafka_room_entry_notifications.template.xml
Outdated
Show resolved
Hide resolved
remove un-needed print_r change "@TOPIC_NAME@" to "entry" remove "template" from filename in script use "strlen" for "array_filter" instead of default filter callback
yossipapi
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add kafka event notification template for roomEntry changes
raise event also if it doesn't require any permission