New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pagination fix #820
Pagination fix #820
Conversation
…blem across different versions of AR
…tring interpolation.
… BY, legal in MySQL. Unfortunately untestable with SQLite
Many specs including the newly added specs are failing. This code would also introduce a dependency that is a private Rails API and I'm not sure if we should go with this. |
I'll look into the specs. I don't see any perfect solutions to the problem this addresses:
Thank you! |
Locally, the activerecord 4* tests pass, but 32 does not work at all:
|
I'm closing this issue in favor of #573. |
But thank you for your contribution! |
This is based on the work here:
https://github.com/amatsuda/kaminari/pull/573
But includes a fix for this change:
rails/rails#18379